Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of kurbo,cairo, pango deps #571

Merged
merged 2 commits into from
Oct 19, 2024

Conversation

flxzt
Copy link
Collaborator

@flxzt flxzt commented Jul 13, 2024

Simply bumping the versions seems to be enough, there are no API updates that would require any changes in piet this time (see changelog here)

@flxzt flxzt changed the title Bump versions of cairo, pango deps Bump versions of kurbo,cairo, pango deps Jul 13, 2024
@xStrom
Copy link
Member

xStrom commented Oct 18, 2024

As a first step we need to get the CI passing. I have done the required work to have master pass CI, which is in #573. It still requires review. I invited you as a collaborator so that you can review and approve that.

@xStrom
Copy link
Member

xStrom commented Oct 18, 2024

Alright now with #573 merged this PR here needs to be rebased on master.

@flxzt
Copy link
Collaborator Author

flxzt commented Oct 18, 2024

Okay, I rebased on master and applied clippy's suggestions to replace a deprecated function from kurbo.
From my side this is now ready.

@flxzt flxzt requested a review from xStrom October 18, 2024 20:13
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We have a general policy that the PR author presses the merge button after approvals. This is because the author might want additional reviews or to make additional changes.

So go ahead and press the merge button when you're ready.

@flxzt
Copy link
Collaborator Author

flxzt commented Oct 19, 2024

Alright, thank you for making the effort to get this merged!

@flxzt flxzt added this pull request to the merge queue Oct 19, 2024
Merged via the queue into linebender:master with commit 8b06c7b Oct 19, 2024
13 checks passed
@flxzt flxzt deleted the bump-cairo-pango branch October 19, 2024 10:07
@xStrom xStrom added this to the v0.7.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants